Hi Kevin, On 2019/11/11 22:44, Kevin Hilman wrote: > Hi Jianxin, > > Jianxin Pan <jianxin.pan@xxxxxxxxxxx> writes: > > [...] > >>>> + SEC_PD(RAMB, GENPD_FLAG_ALWAYS_ON), >>>> + SEC_PD(IR, 0), >>>> + SEC_PD(SPICC, 0), >>>> + SEC_PD(SPIFC, 0), >>>> + SEC_PD(USB, 0), >>>> + /* NIC is for NIC400, and should be always on */ >>> >>> Why? >>> >> NIC domain is for ARM CoreLink NIC-400 Network Interconnect, and should be always on since bootloader. > > OK, makes sense. I suggest a minor change to the comment to remind that > this is an interconnect: > > /* NIC is for the Arm NIC-400 interconnect, and should be always on */ > OK, I will update it, and thanks for the advice. > Thanks, > > Kevin > > . >