Hi Jianxin,
Jianxin Pan <jianxin.pan@xxxxxxxxxxx> writes:
> Add support for the Amlogic Secure Power controller. In A1/C1 series, power
> control registers are in secure domain, and should be accessed by smc.
>
> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
This driver is looking pretty good. A few more minor comments below.
[...]
> +static bool pwrc_secure_is_off(struct meson_secure_pwrc_domain *pwrc_domain)
> +{
> + int sts = 1;
What does 'sts' mean? status? or something else? Please use a more
descriptive name.
> + if (meson_sm_call(pwrc_domain->pwrc->fw, SM_PWRC_GET, &sts,
> + pwrc_domain->index, 0, 0, 0, 0) < 0)
> + pr_err("failed to get power domain status\n");
Does any bit in this register mean the power domain is off? I think it
would be better (and more future proof) if you checked the specific bit
(or mask)
> + return !!sts;
and then:
return sts & bitmask;
> +}
> +
> +static int meson_secure_pwrc_off(struct generic_pm_domain *domain)
> +{
> + int sts = 0;
Like above, what does sts mean?
> + struct meson_secure_pwrc_domain *pwrc_domain =
> + container_of(domain, struct meson_secure_pwrc_domain, base);
> +
> + if (meson_sm_call(pwrc_domain->pwrc->fw, SM_PWRC_SET, NULL,
> + pwrc_domain->index, PWRC_OFF, 0, 0, 0) < 0) {
> + pr_err("failed to set power domain off\n");
> + sts = -EINVAL;
> + }
> +
> + return sts;
It looks to me like sts is only used as a return code, so maybe call it
ret for clarity? or rename it to something more descriptive.
> +}
> +
> +static int meson_secure_pwrc_on(struct generic_pm_domain *domain)
> +{
> + int sts = 0;
> + struct meson_secure_pwrc_domain *pwrc_domain =
> + container_of(domain, struct meson_secure_pwrc_domain, base);
> +
> + if (meson_sm_call(pwrc_domain->pwrc->fw, SM_PWRC_SET, NULL,
> + pwrc_domain->index, PWRC_ON, 0, 0, 0) < 0) {
> + pr_err("failed to set power domain on\n");
> + sts = -EINVAL;
> + }
> +
> + return sts;
same comment as above.
> +}
> +
> +#define SEC_PD(__name, __flag) \
> +[PWRC_##__name##_ID] = \
> +{ \
> + .name = #__name, \
> + .index = PWRC_##__name##_ID, \
> + .is_off = pwrc_secure_is_off, \
> + .flags = __flag, \
> +}
> +
> +static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = {
> + SEC_PD(DSPA, 0),
> + SEC_PD(DSPB, 0),
> + /* UART should keep working in ATF after suspend and before resume */
> + SEC_PD(UART, GENPD_FLAG_ALWAYS_ON),
> + /* DMC is for DDR PHY ana/dig and DMC, and should be always on */
> + SEC_PD(DMC, GENPD_FLAG_ALWAYS_ON),
> + SEC_PD(I2C, 0),
> + SEC_PD(PSRAM, 0),
> + SEC_PD(ACODEC, 0),
> + SEC_PD(AUDIO, 0),
> + SEC_PD(OTP, 0),
> + SEC_PD(DMA, 0),
> + SEC_PD(SD_EMMC, 0),
> + SEC_PD(RAMA, 0),
> + /* SRAMB is used as AFT runtime memory, and should be always on */
AFT? I assume you mean ATF?
> + SEC_PD(RAMB, GENPD_FLAG_ALWAYS_ON),
> + SEC_PD(IR, 0),
> + SEC_PD(SPICC, 0),
> + SEC_PD(SPIFC, 0),
> + SEC_PD(USB, 0),
> + /* NIC is for NIC400, and should be always on */
Why?
> + SEC_PD(NIC, GENPD_FLAG_ALWAYS_ON),
> + SEC_PD(PDMIN, 0),
> + SEC_PD(RSA, 0),
> +};
[...]
Kevin
