Re: [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,


Le lun., nov. 4, 2019 at 07:52, Rob Herring <robh+dt@xxxxxxxxxx> a écrit :
On Sun, Nov 3, 2019 at 4:08 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:

 Add documentation about the devicetree bindings for the generic USB
 charger.

What makes it generic?

It only uses the USB PHY subsystem, which already has some half-baked support for chargers but not bound to the power-supply subsystem.



 Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 ---
.../bindings/power/supply/usb-charger.txt | 24 +++++++++++++++++++
  1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/usb-charger.txt

diff --git a/Documentation/devicetree/bindings/power/supply/usb-charger.txt b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
 new file mode 100644
 index 000000000000..fd46734cb0e5
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
 @@ -0,0 +1,24 @@
 +Generic USB charger bindings
 +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 +
 +Required properties :
 + - compatible : should be "usb-charger"
 + - phys: phandle to the USB PHY
 +
 +Example:
 +
 +usb_con: extcon {
 +       compatible = "linux,extcon-usb-gpio";
 +       vbus-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
 +};
 +
 +usb_phy: usb-phy@0 {
 +       compatible = "usb-nop-xceiv";
 +       #phy-cells = <0>;
 +       extcon = <&usb_con>;

extcon is deprecated in favor of usb-connector binding. See
.../bindings/connector/usb-connector.txt. There's also some pending
patches for adding GPIO based connector controls including Vbus sense
(GPIO input) and control (regulator via a GPIO).

Rob

I understand that the usb-connector binding is better, but the current code doesn't integrate at all with the USB PHY subsystem, which has its own code to handle ID and VBUS GPIOs and supports notifiers. Is that deprecated then?

What's the big picture here?

Thanks,
-Paul







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux