Hi Markus,
Am Montag, 4. November 2019, 15:08:55 CET schrieb Markus Reichl:
> For rk3399-roc-pc is a mezzanine board available that carries M.2 and
> POE interfaces. Use it with a separate dts.
>
> Signed-off-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
> ---
> v2: Add new compatible string for roc-pc with mezzanine board.
> ---
> .../devicetree/bindings/arm/rockchip.yaml | 7 +-
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3399-roc-pc-mezz.dts | 72 ++
> .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 757 +----------------
> .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 770 ++++++++++++++++++
> 5 files changed, 850 insertions(+), 757 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index bf86e8237363..e46af071a5fe 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -87,11 +87,16 @@ properties:
> - const: firefly,roc-rk3328-cc
> - const: rockchip,rk3328
>
> - - description: Firefly ROC-RK3399-PC
> + - description: Firefly ROC-RK3399-PC standalone
> items:
> - const: firefly,roc-rk3399-pc
> - const: rockchip,rk3399
>
> + - description: Firefly ROC-RK3399-PC with mezzanine
> + items:
> + - const: firefly,roc-rk3399-pc-mezz
> + - const: rockchip,rk3399
> +
Please do this similar to like the NanoPC boards, so like
- description: Firefly ROC-RK3399-PC
items:
- enum:
- firefly,roc-rk3399-pc
- firefly,roc-rk3399-pc-mezzanine
- const: rockchip,rk3399
including using the full name (-mezzanine) here and in the
actual dts filename+compatible.
Thanks
Heiko
