Hi, On 30/10/2019 14:43, Fabrizio Castro wrote: > In an effort to repurpose lvds-encoder.c to also serve the > function of LVDS decoders, we ended up defining a new "generic" > compatible string, therefore adapt the dt-bindings to fit the > new purpose. You should convert it to dt-schemas in this case. Neil > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > --- > .../bindings/display/bridge/lvds-codec.txt | 100 +++++++++++++++++++++ > .../bindings/display/bridge/lvds-transmitter.txt | 66 -------------- > 2 files changed, 100 insertions(+), 66 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-codec.txt > delete mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.txt b/Documentation/devicetree/bindings/display/bridge/lvds-codec.txt > new file mode 100644 > index 0000000..45fd81c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.txt > @@ -0,0 +1,100 @@ > +Trasnparent LVDS encoders and LVDS decoders > +------------------------------------------- > + > +This binding supports transparent LVDS encoders and LVDS decoders that don't > +require any configuration. > + > +LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > +incompatible data link layers have been used over time to transmit image data > +to LVDS panels. This binding targets devices compatible with the following > +specifications only. > + > +[JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > +1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > +[LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > +Semiconductor > +[VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > +Electronics Standards Association (VESA) > + > +Those devices have been marketed under the FPD-Link and FlatLink brand names > +among others. > + > + > +Required properties: > + > +- compatible: Must be "lvds-encoder" for LVDS encoders or "lvds-decoder" for > + LVDS decoders. > + > + Any encoder compatible with this generic binding, but with additional > + properties not listed here, must list a device specific compatible first > + followed by the generic compatible. > + > +Required nodes: > + > +This device has two video ports. Their connections are modeled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +For LVDS encoders: > +- Video port 0 for parallel input > +- Video port 1 for LVDS output > + > +For LVDS decoders: > +- Video port 0 for LVDS input > +- Video port 1 for parallel output > + > + > +LVDS encoder example > +-------------------- > + > +lvds-encoder { > + compatible = "lvds-encoder"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + lvds_enc_in: endpoint { > + remote-endpoint = <&display_out_rgb>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + lvds_enc_out: endpoint { > + remote-endpoint = <&lvds_panel_in>; > + }; > + }; > + }; > +}; > + > +LVDS decoder example > +-------------------- > + > +lvds-decoder { > + compatible = "lvds-decoder"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + lvds_dec_in: endpoint { > + remote-endpoint = <&display_out_lvds>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + lvds_dec_out: endpoint { > + remote-endpoint = <&rgb_panel_in>; > + }; > + }; > + }; > +}; > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > deleted file mode 100644 > index 60091db..0000000 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ /dev/null > @@ -1,66 +0,0 @@ > -Parallel to LVDS Encoder > ------------------------- > - > -This binding supports the parallel to LVDS encoders that don't require any > -configuration. > - > -LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > -incompatible data link layers have been used over time to transmit image data > -to LVDS panels. This binding targets devices compatible with the following > -specifications only. > - > -[JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > -1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > -[LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > -Semiconductor > -[VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > -Electronics Standards Association (VESA) > - > -Those devices have been marketed under the FPD-Link and FlatLink brand names > -among others. > - > - > -Required properties: > - > -- compatible: Must be "lvds-encoder" > - > - Any encoder compatible with this generic binding, but with additional > - properties not listed here, must list a device specific compatible first > - followed by this generic compatible. > - > -Required nodes: > - > -This device has two video ports. Their connections are modeled using the OF > -graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - > -- Video port 0 for parallel input > -- Video port 1 for LVDS output > - > - > -Example > -------- > - > -lvds-encoder { > - compatible = "lvds-encoder"; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - lvds_enc_in: endpoint { > - remote-endpoint = <&display_out_rgb>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - lvds_enc_out: endpoint { > - remote-endpoint = <&lvds_panel_in>; > - }; > - }; > - }; > -}; >