Hi Paul, I love your patch! Yet something to improve: [auto build test ERROR on power-supply/for-next] [cannot apply to v5.4-rc6 next-20191031] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Paul-Cercueil/dt-bindings-power-supply-Document-generic-USB-charger/20191104-061214 base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): >> drivers/power/supply/generic-usb-charger.c:131:21: error: implicit declaration of function 'of_match_ptr'; did you mean 'usb_match_id'? [-Werror=implicit-function-declaration] .of_match_table = of_match_ptr(usb_charger_of_match), ^~~~~~~~~~~~ usb_match_id >> drivers/power/supply/generic-usb-charger.c:131:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion] drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table') >> drivers/power/supply/generic-usb-charger.c:131:21: error: initializer element is not constant drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table') cc1: some warnings being treated as errors vim +131 drivers/power/supply/generic-usb-charger.c 127 128 static struct platform_driver usb_charger_driver = { 129 .driver = { 130 .name = "usb-charger", > 131 .of_match_table = of_match_ptr(usb_charger_of_match), 132 }, 133 .probe = usb_charger_probe, 134 .remove = usb_charger_remove, 135 }; 136 module_platform_driver(usb_charger_driver); 137 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
