Hi Tudor,
On Fri, Nov 01, 2019 at 01:48:17PM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
>
>
> On 10/30/2019 11:01 AM, Manivannan Sadhasivam wrote:
> > External E-Mail
> >
> >
> > Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> > supports dual/quad I/O mode with 512 blocks of memory organized in
> > 64KB sectors. In addition to this, there is also small 4KB sectors
> > available for flexibility. The device has been validated using Thor96
> > board.
> >
> > Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> > Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> > Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> > Cc: Brian Norris <computersforpeace@xxxxxxxxx>
> > Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > Cc: Richard Weinberger <richard@xxxxxx>
> > Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> > Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Darshak Patel <darshak.patel@xxxxxxxxxxxxxx>
> > [Mani: cleaned up for upstream]
>
> Can we keep Darshak's authorship? We usually change the author if we feel that
> we made a significant change to what was originally published.
>
> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> after the author's S-o-b tag and then add your S-o-b, as you did above.
>
I'd suggest to keep Darshak's authorship since he did the actual change in
the bsp. I have to clean it up before submitting upstream and I mentioned
the same above.
> The patch looks good.
>
Thanks,
Mani
> Cheers,
> ta
>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 1d8621d43160..2c25b371d9f0 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
> > { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
> > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > + { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >
> >
