On Thu, Oct 31, 2019 at 4:02 AM Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> wrote: > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/ov8856.yaml | 126 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 127 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.yaml Need to test this with 'make dt-binding-check': warning: no schema found in file: Documentation/devicetree/bindings/media/i2c/ov8856.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ov8856.yaml: ignoring, error parsing file Documentation/devicetree/bindings/media/i2c/ov8856.yaml: while scanning a simple key in "<unicode string>", line 81, column 5 could not find expected ':' in "<unicode string>", line 84, column 1 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/i2c/ov8856.example.dts' failed > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > new file mode 100644 > index 0000000..a161812 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > @@ -0,0 +1,126 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2019 MediaTek Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ov8856.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings > + > +maintainers: > + - Ben Kao <ben.kao@xxxxxxxxx> > + - Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > + > +description: |- > + The Omnivision OV8856 is a high performance, 1/4-inch, 8 megapixel, CMOS > + image sensor that delivers 3264x2448 at 30fps. It provides full-frame, > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > + Serial Camera Control Bus (SCCB) interface. This chip is programmable > + through I2C and two-wire SCCB. The sensor output is available via CSI-2 > + serial data output (up to 4-lane). > + > +properties: > + compatible: > + const: ovti,ov8856 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Input clock for the sensor. > + items: > + - const: xvclk > + > + clock-frequency: > + description: > + Frequency of the xvclk clock in Hertz. > + > + dovdd-supply: > + description: > + Definition of the regulator used as interface power supply. > + maxItems: 1 Drop maxItems, it's always a single phandle. > + > + avdd-supply: > + description: > + Definition of the regulator used as analog power supply. > + maxItems: 1 > + > + dvdd-supply: > + description: > + Definition of the regulator used as digital power supply. > + maxItems: 1 > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls sensor reset. > + maxItems: 1 > + > + # See ../video-interfaces.txt for details > + port: > + type: object > + additionalProperties: false > + > + properties: > + endpoint: > + type: object > + > + properties: > + remote-endpoint: true > + data-lanes: true > + link-frequencies: true > + > + required: > + - remote-endpoint > + - data-lanes > + - link-frequencies > + > + required Missing ':' is the cause of the error above. > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - clock-frequency > + - dovdd-supply > + - avdd-supply > + - dvdd-supply > + - reset-gpios > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + ov8856: camera-sensor@10 { > + compatible = "ovti,ov8856"; > + reg = <0x10>; > + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cru SCLK_TESTCLKOUT1>; > + clock-names = "xvclk"; > + clock-frequency = <19200000>; > + > + avdd-supply = <&mt6358_vcama2_reg>; > + dvdd-supply = <&mt6358_vcamd_reg>; > + dovdd-supply = <&mt6358_vcamio_reg>; > + > + port { > + wcam_out: endpoint { > + remote-endpoint = <&mipi_in_wcam>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <360000000 180000000>; > + }; > + }; > + }; > + > +... > \ No newline at end of file > diff --git a/MAINTAINERS b/MAINTAINERS > index 296de2b..4cbae26 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12037,6 +12037,7 @@ L: linux-media@xxxxxxxxxxxxxxx > T: git git://linuxtv.org/media_tree.git > S: Maintained > F: drivers/media/i2c/ov8856.c > +F: Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > OMNIVISION OV9650 SENSOR DRIVER > M: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > -- > 2.9.2 >
