On 31.10.19 14:07, Krzysztof Kozlowski wrote:
> On Tue, Oct 29, 2019 at 11:28:16AM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
>> ---
>> arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> index 5bad29683cc3..295bc3138fea 100644
>> --- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> @@ -7,6 +7,9 @@
>>
>> #include "imx6ul-kontron-n6310-s.dts"
>>
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/gpio/gpio.h>
>
> This is not needed. This includes imx6ul-kontron-n6310-s.dts, which
> includes imx6ul-kontron-n6310-som.dtsi which has proper GPIO include. It
> also polls imx6ul.dtsi which has the IRQ defines.
>
> My comment from v1 was for a case where you have a DTSI standing on its
> own. If it does not include anything else, then it should have all
> necessary inclusions (not only GPIO but also iMX-specific pinctrl and clock).
Ok, got it. Thanks for clarifying.
This patch can be dropped then.
>
> Best regards,
> Krzysztof
>
>
>> +
>> / {
>> model = "Kontron N6310 S 43";
>> compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",
>> --
>> 2.17.1
