Hi, Shawn > On Wed, Oct 16, 2019 at 10:14:23AM +0800, Anson Huang wrote: > > usdhc's clock rate is different according to different devices > > connected, so clock rate assignment should be placed in board DT > > according to different devices connected on each usdhc port. > > I think it should be fine that we have a reasonable default settings in soc.dtsi, > and boards that need a different setup can overwrite the settings in > board.dts. Someone was complaining about the usdhc clock assignment in soc.dtsi, because some usdhc nodes are having clock assignments while some are NOT. That is why I did this patch set. I agree that we can have default settings in soc.dtsi, so do you think it makes sense to add default clock assignment to all usdhc nodes? If yes, I will redo the patch set. Thanks, Anson.