On Thu, Oct 24, 2019 at 01:09:06PM +0300, Grygorii Strashko wrote: > As a preparatory patch to add support for a switchdev based cpsw driver, > move common functions to cpsw-priv.c so that they can be used across both > drivers. Hi Grygorii Bike shedding, but it seems odd to move common code into a private file. How common is the current code in cpsw-common.c? Andrew