Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Friday, October 25, 2019 4:54 PM
>
> Hi Shimoda-san,
>
> On Fri, Oct 25, 2019 at 3:42 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > From: Geert Uytterhoeven, Sent: Thursday, October 24, 2019 8:26 PM
> > <snip>
> > > > This hardware needs to deassert resets of both host and peripheral.
> > > > So, this patch adds reset control.
> > >
> > > If the hardware needs it, probably you want to make CLK_RCAR_USB2_CLOCK_SEL
> > > select RESET_CONTROLLER?
> >
> > You're correct. I'll fix it.
> >
> > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > >
> > > > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > > > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > >
> > > > @@ -164,6 +172,10 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
> > > > if (IS_ERR(priv->clks[CLK_INDEX_HS_USB]))
> > > > return PTR_ERR(priv->clks[CLK_INDEX_HS_USB]);
> > > >
> > > > + priv->rsts = devm_reset_control_array_get_optional_shared(&pdev->dev);
> > >
> > > If the reset is really needed, you should not use the optional API.
> >
> > That's true. So, I'll use devm_reset_control_array_get(&pdev->dev, true, false)
>
> Any reason you need the array version? Are there multiple resets to be
> specified?
Yes, there are multiple resets (<&cpg 703> and <&cpg 704>) to be specified.
> No longer shared?
This hardware shares the resets with USB host (EHCI and OHCI),
USB Function (HS-USB) and USB2-PHY...
> Which brings to my attention you forgot to document the resets in the
> DT bindings ;-)
That's right. I'll add the resets property.
Best regards,
Yoshihiro Shimoda
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
