Hi Neil, On Mon, Oct 21, 2019 at 3:23 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: [...] > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > new file mode 100644 > index 000000000000..45bcc98ee9a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson G12A DWC3 USB SoC Controller Glue > + > +maintainers: > + - Neil Armstrong <narmstrong@xxxxxxxxxxxx> > + > +description: | > + The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 > + in host-only mode, and a DWC2 IP Core configured for USB2 peripheral mode > + only. > + > + A glue connects the DWC3 core to USB2 PHYs and optionnaly to an USB3 PHY. optionnaly -> optionally > + > + One of the USB2 PHY can be re-routed in peripheral mode to a DWC2 USB IP. One of the USB2 PHYs... with these two fixed: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> [...] > + phy-names: > + items: > + - const: usb2-phy0 # USB2 PHY0 if USBHOST_A port is used > + - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used > + - const: usb3-phy0 # USB3 PHY if USB3_0 is used > + > + phys: > + minItems: 1 > + maxItems: 3 (off-topic and probably a question for Rob: do you know the validation mechanism knows that phys and phy-names belong together. so if one phy is omitted then phy-names can be shorter than 3 entries?) Martin