On Mon, Oct 07, 2019 at 10:17:03AM -0500, Benoit Parrot wrote: > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote on Mon [2019-Oct-07 11:03:20 +0300]: > > On Fri, Oct 04, 2019 at 12:24:16PM -0500, Benoit Parrot wrote: > > > @@ -2657,6 +2669,12 @@ static int ov5640_init_controls(struct ov5640_dev *sensor) > > > /* we can use our own mutex for the ctrl lock */ > > > hdl->lock = &sensor->lock; > > > > > > + /* Clock related controls */ > > > + ctrls->pixel_rate = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_PIXEL_RATE, > > > + 0, INT_MAX, 1, > > > + ov5640_calc_pixel_rate(sensor)); > > > + ctrls->pixel_rate->flags |= V4L2_CTRL_FLAG_READ_ONLY; > > > > Please check ctrls->pixel_rate first; it may be NULL here. > > How about I just move this line below "if (hdl->error)" instead? That's fine, too. As long as it won't oops if memory allocation fails... :-) -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
