Hi, On Tue, Oct 1, 2019 at 10:41 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Thu, Sep 26, 2019 at 12:41:18PM -0700, Douglas Anderson wrote: > > > - description: bootloader/firmware enabled regulator > > + description: bootloader/firmware enabled regulator. > > + It's expected that this regulator was left on by the bootloader. > > + If the bootloader didn't leave it on then OS should turn it on > > + at boot but shouldn't prevent it from being turned off later. > > This is good... > > > + This property is intended to only be used for regulators where > > + Linux cannot read the state of the regulator at bootup. > > ...but we shouldn't say "Linux" here since the DT binding is for all > OSs, not just Linux. I'd say "software" instead. Really the > expectation is that things wouldn't support readback at all, though it's > possible there's some weird hardware out there that will support > readback some of the time I guess. Argh. I knew not to mention "Linux" and kept it in mind to write the first part. ...but then I must have just spaced. I also removed the "at bootup" part since it seemed better. -Doug