Re: [PATCH v3 3/3] arm64: dts: qcom: msm8996: Update simple-pm-bus node name to 'bus'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Tue, Sep 24, 2019 at 11:37 AM Simon Horman
<horms+renesas@xxxxxxxxxxxx> wrote:
> Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the
> proposed binding description in json-schema which in turn reflects the ePAR
> standard - "the name of a node should be somewhat generic, reflecting the
> function of the device and not its precise programming model."
>
> Also drop the unit address as there is neither a reg property nor
> non-empty ranges.
>
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
> v2
> * New patch
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 96c0a481f454..99f376ebd27e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1373,7 +1373,7 @@
>                         clock-names = "iface", "bus";
>                 };
>
> -               agnoc@0 {
> +               bus {
>                         power-domains = <&gcc AGGRE0_NOC_GDSC>;
>                         compatible = "simple-pm-bus";
>                         #address-cells = <1>;

This file is included by arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi,
which references agnoc@0, so you have to update that one as well,
to avoid introducing silent breakages.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux