Hi Martin, On 2019/9/20 4:06, Martin Blumenstingl wrote: > Hi Jianxin, > > On Thu, Sep 19, 2019 at 2:11 PM Jianxin Pan <jianxin.pan@xxxxxxxxxxx> wrote: >> >> Add the bindings for the Amlogic Secure power domains, controlling the >> secure power domains. >> >> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the >> power domain registers are in secure world. >> >> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx> >> Signed-off-by: Zhiqiang Liang <zhiqiang.liang@xxxxxxxxxxx> >> --- >> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 32 ++++++++++++++++++++++ >> include/dt-bindings/power/meson-a1-power.h | 32 ++++++++++++++++++++++ >> 2 files changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> create mode 100644 include/dt-bindings/power/meson-a1-power.h >> >> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> new file mode 100644 >> index 00000000..327e0d9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> @@ -0,0 +1,32 @@ >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) [...]>> +examples: >> + - | >> + pwrc: power-controller { >> + compatible = "amlogic,meson-a1-pwrc"; >> + }; > not a comment about this binding but about the secure monitor in general: > there's a recent discussion about the secure monitor in the nvmem bindings: [0] > > > Martin > > > [0] https://www.spinics.net/lists/arm-kernel/msg750010.html > Thanks for your remind,I will update and send the second version after Rework of secure-monitor driver is applied. > . >