Re: [PATCH input-next 1/4] dt-bindings: input: Convert mpr121 binding to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03. 09. 19 8:56, Rob Herring wrote:
On Mon, Sep 02, 2019 at 01:40:14PM +0200, Michal Vokáč wrote:
Convert the mpr121 binding to DT schema format using json-schema.

Signed-off-by: Michal Vokáč <michal.vokac@xxxxxxxxx>
---
Hi Rob,

I will appreciate your help converting this binding. Currently
the scheme is not valid and the error output of dt_binding_check
is not really helpful.

What's the error? I don't see anything obvious.

After some trial & error attempts I found few issues:

 - Wrong placement of description for wakeup-source. Solved.
 - Missing coma between <KEY_4>, <KEY_5> values in the example. Solved.
 - DTC complained about invalid reg property length in the example.
   Solved by placing the mpr121 subnode into i2c {}; node and adding
   #address-cells and #size-cells properties.
 - The linux,keycodes property also requires type definition. Unresolved.

   What type should be used? Neither uint32-array nor uint32-matrix work.
   The linux,keycodes list is not correctly validated against the maxItems
   value. When I set maxItems less then the number of keycodes, it does not
   complain.

Also, who shoud be the maintainer of this binding?
I put Dmitry in there as he is the input subsystem maintainer but
I am not sure it is correct.

My preference is the author or driver maintainer.

Then Dmitry seems to be the best match here I think.

  .../bindings/input/fsl,mpr121-touchkey.yaml        | 64 ++++++++++++++++++++++
  .../devicetree/bindings/input/mpr121-touchkey.txt  | 30 ----------
  2 files changed, 64 insertions(+), 30 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
  delete mode 100644 Documentation/devicetree/bindings/input/mpr121-touchkey.txt




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux