On Tue, Sep 17, 2019 at 2:31 AM Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote: > > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in general, there may be a case where > 'mac-mode' becomes more generic and is moved as part of phylib or netdev. > > In any case, the 'mac-mode' field should be made an enum, and it also makes > sense to just reference the 'phy-connection-type' from > 'ethernet-controller.yaml'. That will also make it more future-proof for new > modes. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
