Hi Dongchun, On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote: ... > > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies); > > > + if (ret < 0) { > > > + dev_err(dev, "Failed to enable regulators\n"); > > > + goto disable_clk; > > > + } > > > + msleep_range(7); > > > > This has some potential of clashing with more generic functions in the > > future. Please use usleep_range directly, or msleep. > > > > Did you mean using usleep_range(7*1000, 8*1000), as used in patch v1? > https://patchwork.kernel.org/patch/10957225/ Yes, please. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx