> > + leds {
> > + compatible = "gpio-leds";
> > + red {
> > + gpios = <&gpiosb 21 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "default-on";
> > + };
I think there would normally be a label here, so the LED has a
name. There is a convention to follow, which is in the documentation.
> > + };
> > +
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > +
> > + reset {
> > + label = "reset";
> > + linux,code = <BTN_MISC>;
I'm pretty sure there is a linux,code for reset.
> > + gpios = <&gpiosb 20 GPIO_ACTIVE_LOW>;
> > + debounce-interval = <60>;
> > + };
> > + };
> > +
> > + sfp: sfp {
> > + compatible = "sff,sfp+";
> > + i2c-bus = <&i2c0>;
The standard for SFPs sets the maximum bus speed is 100Khz. I'm sure
some can do 400Khz, but if you want to support all SFPs, you should
use the lower speed. I don't see anywhere in this file where you set
the maximum speed. Maybe the bus defaults to 100K so you don't need
anything?
> > + los-gpio = <&moxtet_sfp 0 GPIO_ACTIVE_HIGH>;
> > + tx-fault-gpio = <&moxtet_sfp 1 GPIO_ACTIVE_HIGH>;
> > + mod-def0-gpio = <&moxtet_sfp 2 GPIO_ACTIVE_LOW>;
> > + tx-disable-gpio = <&moxtet_sfp 4 GPIO_ACTIVE_HIGH>;
> > + rate-select0-gpio = <&moxtet_sfp 5 GPIO_ACTIVE_HIGH>;
> > +
> > + /* enabled by U-Boot if SFP module is present */
> > + status = "disabled";
> > + };
> > +};
> > +
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c1_pins>;
The node is called i2c0, but here you have i2c1_pins?
> > + status = "okay";
> > +
> > + rtc@6f {
> > + compatible = "microchip,mcp7940x";
> > + reg = <0x6f>;
> > + };
> > +};
> > +
> > +&pcie_reset_pins {
> > + function = "gpio";
> > +};
Should there be something to indicate which GPIO?
> > +&mdio {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&smi_pins>;
> > + status = "okay";
> > +
> > + phy1: ethernet-phy@1 {
> > + reg = <1>;
> > + };
> > +
> > + /* switch nodes are enabled by U-Boot if modules are present */
> > + switch0@10 {
> > + compatible = "marvell,mv88e6190";
> > + reg = <0x10 0>;
> > + dsa,member = <0 0>;
> > + interrupt-parent = <&moxtet>;
> > + interrupts = <MOXTET_IRQ_PERIDOT(0)>;
> > + status = "disabled";
> > +
> > + mdio {
> > + ports {
> > + switch0port10: port@a {
> > + reg = <0xa>;
> > + label = "dsa";
> > + phy-mode = "2500base-x";
> > + managed = "in-band-status";
> > + link = <&switch1port9 &switch2port9>;
Does u-boot also modify this, if switch2 does not exist? I don't know
if it actually matters, but if the switch does not exist, but the
routing entry exists, this switch might still send it frames and use
up some of your bandwidth?
Andrew
