On Wed, Aug 21, 2019 at 06:47:43PM +0300, Jonathan Chocron wrote:
> Document Amazon's Annapurna Labs PCIe host bridge.
>
> Signed-off-by: Jonathan Chocron <jonnyc@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pci/pcie-al.txt | 46 +++++++++++++++++++
> MAINTAINERS | 3 +-
> 2 files changed, 48 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/pci/pcie-al.txt
>
> diff --git a/Documentation/devicetree/bindings/pci/pcie-al.txt b/Documentation/devicetree/bindings/pci/pcie-al.txt
> new file mode 100644
> index 000000000000..557a5089229d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/pcie-al.txt
> @@ -0,0 +1,46 @@
> +* Amazon Annapurna Labs PCIe host bridge
> +
> +Amazon's Annapurna Labs PCIe Host Controller is based on the Synopsys DesignWare
> +PCI core. It inherits common properties defined in
> +Documentation/devicetree/bindings/pci/designware-pcie.txt.
> +
> +Properties of the host controller node that differ from it are:
> +
> +- compatible:
> + Usage: required
> + Value type: <stringlist>
> + Definition: Value should contain
> + - "amazon,al-alpine-v2-pcie" for alpine_v2
> + - "amazon,al-alpine-v3-pcie" for alpine_v3
> +
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Register ranges as listed in the reg-names property
> +
> +- reg-names:
> + Usage: required
> + Value type: <stringlist>
> + Definition: Must include the following entries
> + - "config" PCIe ECAM space
> + - "controller" AL proprietary registers
> + - "dbi" Designware PCIe registers
> +
> +Example:
> +
> + pcie-external0: pcie@fb600000 {
> + compatible = "amazon,al-alpine-v3-pcie";
> + reg = <0x0 0xfb600000 0x0 0x00100000
> + 0x0 0xfd800000 0x0 0x00010000
> + 0x0 0xfd810000 0x0 0x00001000>;
> + reg-names = "config", "controller", "dbi";
> + bus-range = <0 255>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-map-mask = <0x00 0 0 7>;
> + interrupt-map = <0x0000 0 0 1 &gic GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; /* INTa */
> + ranges = <0x02000000 0x0 0xc0010000 0x0 0xc0010000 0x0 0x07ff0000>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 783569e3c4b4..d200b16fa95c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12448,10 +12448,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/
> S: Supported
> F: drivers/pci/controller/
>
> -PCIE DRIVER FOR ANNAPURNA LABS
> +PCIE DRIVER FOR AMAZON ANNAPURNA LABS
> M: Jonathan Chocron <jonnyc@xxxxxxxxxx>
> L: linux-pci@xxxxxxxxxxxxxxx
> S: Maintained
> +F: Documentation/devicetree/bindings/pci/pcie-al.txt
> F: drivers/pci/controller/dwc/pcie-al.c
>
> PCIE DRIVER FOR AMLOGIC MESON
I'm not sure if you need to split out the DT part of this patch, perhaps
others will comment.
But for both:
Reviewed-by: Andrew Murray <andrew.murray@xxxxxxx>
> --
> 2.17.1
>
