On Mon, Aug 19, 2019 at 10:59:36AM -0700, Stephen Boyd wrote: > Quoting Niklas Cassel (2019-08-19 03:09:57) > > + > > +soc { > > +.... > > + cprpd: cpr@b018000 { > > Maybe node name should be 'avs' for the industry standard adaptive > voltage scaling acronym? I see where this is coming from, but "git grep avs" gives a single result. Also, since the label is cprpd, it doesn't make sense to simply rename the node name, and I don't think that avspd would be a good name, since it is less correct. So if you don't insist, I would prefer to leave it as it is. > > > > + compatible = "qcom,qcs404-cpr", "qcom,cpr"; > > + reg = <0x0b018000 0x1000>; > > + .... > > + vdd-apc-supply = <&pms405_s3>; > > + #power-domain-cells = <0>;