Hi Sakari, On Tue, 2019-07-23 at 10:41 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > On Thu, Jul 04, 2019 at 04:46:50PM +0800, dongchun.zhu@xxxxxxxxxxxx wrote: > > From: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > > > Add device tree binding documentation for the OV02A10 camera sensor. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/media/i2c/ov02a10.txt | 43 ++++++++++++++++++++++ > > MAINTAINERS | 7 ++++ > > 2 files changed, 50 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > new file mode 100644 > > index 0000000..d40aa87 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > @@ -0,0 +1,43 @@ > > +* Omnivision OV02A10 MIPI CSI-2 sensor > > + > > +Required Properties: > > +- compatible: shall be "ovti,ov02a10" > > +- clocks: reference to the xvclk input clock > > +- clock-names: shall be "xvclk" > > +- avdd-supply: Analog voltage supply, 2.8 volts > > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > > +- dvdd-supply: Digital core voltage supply, 1.8 volts > > +- reset-gpios: Low active reset gpio > > + > > +The device node shall contain one 'port' child node with an > > +'endpoint' subnode for its digital output video port, in accordance > > +with the video interface bindings defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > +The endpoint optional property 'data-lanes' shall be "<1>". > > How many lanes does the module (or the sensor) have? > >From sensor datasheet, OV02A10 supports 1-lane MIPI interface. > > + > > +Example: > > +&i2c4 { > > +ov02a10: camera-sensor@3d { > > +compatible = "ovti,ov02a10"; > > +reg = <0x3d>; > > +pinctrl-names = "default"; > > +pinctrl-0 = <&camera_pins_cam1_mclk_on>; > > + > > +clocks = <&topckgen CLK_TOP_MUX_CAMTG2>, > > +<&topckgen CLK_TOP_UNIVP_192M_D8>; > > +clock-names = "xvclk", "freq_mux"; > > + > > +avdd-supply = <&mt6358_vcama1_reg>; > > +dvdd-supply = <&mt6358_vcn18_reg>; > > +dovdd-supply = <&mt6358_vcamio_reg>; > > +pwdn-gpios = <&pio 107 1>; > > +reset-gpios = <&pio 109 1>; > > + > > +port { > > + ov02a10_core: endpoint { > > + remote-endpoint = <&ov02a10_0>; > > Indentation is still wrong. :-( > Fixed in next release. > > + data-lanes = <1>; > > +}; > > +}; > > +}; > > +}; > > diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4..62b81ff 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11571,6 +11571,13 @@ T:git git://linuxtv.org/media_tree.git > > S:Maintained > > F:drivers/media/i2c/ov13858.c > > > > +OMNIVISION OV02A10 SENSOR DRIVER > > +M:Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > +L:linux-media@xxxxxxxxxxxxxxx > > +T:git git://linuxtv.org/media_tree.git > > +S:Maintained > > +F:Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > + > > OMNIVISION OV2680 SENSOR DRIVER > > M:Rui Miguel Silva <rmfrfs@xxxxxxxxx> > > L:linux-media@xxxxxxxxxxxxxxx > > -- > Kind regards, > > Sakari Ailus > sakari.ailus@xxxxxxxxxxxxxxx > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-mediatek > *********************MEDIATEK Confidential/Internal Use*********************