On Thu, Aug 08, 2019 at 07:54:16PM +0300, Sakari Ailus wrote: > Hi Dongchun, > > (Cc'ing Ben, too.) > > On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun.zhu@xxxxxxxxxxxx wrote: > > From: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > > > Add device tree binding documentation for the ov8856 camera sensor. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/media/i2c/ov8856.txt | 41 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 42 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > > new file mode 100644 > > index 0000000..96b10e0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > > @@ -0,0 +1,41 @@ > > +* Omnivision OV8856 MIPI CSI-2 sensor > > + > > +Required Properties: > > +- compatible: shall be "ovti,ov8856" > > +- clocks: reference to the xvclk input clock > > +- clock-names: shall be "xvclk" > > Could you add "clock-frequency" property here, please, and specify the > upper and lower limits? Can you also add the link-frequencies property, please? -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
