On Thu, Aug 01, 2019 at 12:07:59PM -0700, Matthias Kaehlcke wrote: > Configure the RTL8211E LEDs behavior when the device tree property > 'realtek,led-modes' is specified. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> Hi Matthias I was more thinking of adding a new driver call to the PHY driver API, to configure an LED. Something like rtl8211e_config_leds(phydev, int led, struct phy_led_config cfg); It would be called by the phylib core after config_init(). But also, thinking ahead to generic linux LED support, it could be called later to reconfigure the LEDs to use a different trigger. The standard LED sysfs interface would be used. Andrew