From: Matthias Kaehlcke <mka@xxxxxxxxxxxx> Date: Thu, 1 Aug 2019 12:07:59 -0700 > +static int rtl8211e_config_leds(struct phy_device *phydev) > +{ > + int i, oldpage, ret; > + u16 lacr_bits = 0, lcr_bits = 0; > + u16 lacr_mask = RLT8211E_LACR_LEDACTCTRL_MASK; > + u16 lcr_mask = RTL8211E_LCR_LEDCTRL_MASK; > + bool eed_led_mode_disabled = false; Please use reverse christmas tree ordering here.