Hi Fabrizio, Thank you for the patch. On Fri, Aug 02, 2019 at 08:34:01AM +0100, Fabrizio Castro wrote: > This panel is handled through the generic lvds-panel bindings, > so only needs its additional compatible specified. > > Some panel specific documentation can be found here: s/panel specific/panel-specific/ > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > --- > .../display/panel/advantech,idk-2121wr.txt | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > new file mode 100644 > index 0000000..70b15b6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.txt > @@ -0,0 +1,62 @@ > +Advantech Co., Ltd. IDK-2121WR 21.5" LVDS panel > +=============================================== > + > +Required properties: > +- compatible: should be "advantech,idk-2121wr" followed by "panel-lvds" > + > +This binding is compatible with the lvds-panel binding, which is specified > +in panel-lvds.txt in this directory. How about adding "The panel operates in dual-link mode and thus requires two port nodes." ? > + > +Example > +------- > + > + panel { > + compatible = "advantech,idk-2121wr", "panel-lvds"; > + > + width-mm = <476>; > + height-mm = <268>; > + > + data-mapping = "vesa-24"; > + > + panel-timing { > + clock-frequency = <148500000>; > + hactive = <1920>; > + vactive = <1080>; > + hsync-len = <44>; > + hfront-porch = <88>; > + hback-porch = <148>; > + vfront-porch = <4>; > + vback-porch = <36>; > + vsync-len = <5>; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds0_panel_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds1_panel_in: endpoint { > + remote-endpoint = <&lvds1_out>; > + }; > + }; > + }; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm5 0 50000>; > + > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <6>; > + > + power-supply = <®_12p0v>; > + enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; > + }; I think you can drop the backlight here, it's a bit out of scope. -- Regards, Laurent Pinchart
