Hi Boris, > On Thu, 1 Aug 2019 11:55:10 +0800 > Mason Yang <masonccyang@xxxxxxxxxxx> wrote: > > > Document the bindings used by the Macronix raw NAND controller. > > > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/ > Documentation/devicetree/bindings/mtd/mxic-nand.txt > > new file mode 100644 > > index 0000000..de37d60 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt > > @@ -0,0 +1,19 @@ > > +Macronix Raw NAND Controller Device Tree Bindings > > +------------------------------------------------- > > + > > +Required properties: > > +- compatible: should be "mxicy,multi-itfc-v009-nand-morph" > > +- reg: should contain 1 entry for the registers > > +- interrupts: interrupt line connected to this raw NAND controller > > +- clock-names: should contain "ps", "send" and "send_dly" > > +- clocks: should contain 3 phandles for the "ps", "send" and > > + "send_dly" clocks > > + > > +Example: > > + > > + nand: nand-controller@43c30000 { > > + compatible = "mxicy,multi-itfc-v009-nand-morph"; > > + reg = <0x43c30000 0x10000>; > > + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>; > > + clock-names = "send", "send_dly", "ps"; > > You should have subnodes describing the NAND connected to the > controller (see [1]). > > [1] https://elixir.bootlin.com/linux/v5.3-rc2/source/Documentation/devicetree/ > bindings/mtd/nand-controller.yaml#L131 > > > + }; > Do you mean to add patternProperties ? nand: nand-controller@43c30000 { compatible = "mxicy,multi-itfc-v009-nand-morph"; reg = <0x43c30000 0x10000>; clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>; clock-names = "send", "send_dly", "ps"; + nand@0 { + + }; }; something like that. thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================