On Tue, Jul 30, 2019 at 10:09:00AM +0200, Uwe Kleine-König wrote: > Hello Rob and Frank, > > Maxime and Jernej on one side and me on the other cannot agree about a > detail in the change to the bindings here. I'm trying to objectively > summarize the situation for you to help deciding what is the right thing > to do here. > > TLDR: The sun4i pwm driver is extended to support a new variant of that > device on the H6 SoC. Compared to the earlier supported variants > allwinner,sun50i-h6-pwm on H6 needs to handle a reset controller and an > additional clock. > > The two positions are: > > - We need a new compatible because only then the driver and/or the dt > schema checker can check that each "allwinner,sun50i-h6-pwm" device > has a reset property and a "bus" clock; and the earlier variants > don't. There is two topics here, really. The binding itself really must have those properties as required. You had an analogy before that we shouldn't really do that, since it would be verification and that it would be similar to checking whether the register range was right. This analogy isn't correct, a better one would be checking that the register range exists in the first place. Indeed, if you don't have a register range, you have no register to write to, and that's a showstopper for any driver. I'm pretty sure we all agree on that. But on those SoCs, like Chen-Yu said, having no resets or clocks properties result in an equally bad result: either any write to that device is completely ignored (missing reset), or the system completely (and silently) locks up (missing bus clock). We *have* to catch that somehow and not let anything like that happen. That being said, we can't really validate that the clock pointed is the right one, just like we can't really check that the register range is the proper one. Or rather, we could, but it's completely impractical and we do agree on that as well. Having the bus clock and reset line being required however is only a few lines in the binding though, and is very practical. > - The driver can be simpler and the device specific knowledge is only > in a single place (the dt) if the device tree is considered valid and > a reset property and "bus" clock is used iff it's provided in the > device tree without additional comparison for the compatible. And now we have the discussion on how it's implemented in a driver. Since it's pretty cheap to implement (only a couple of lines: two for the if block, one for the additional field in the structure, one for each SoC using that) and have huge benefits (not silently locking up the system at boot), then I'd say we should go for it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
