On 30/07/2019 14:12, Marco Felsch wrote: > Hi Charles, > > sorry for jumping in.. > > On 19-07-30 13:27, Charles Keepax wrote: >> On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote: >>> Signed-off-by: Thomas Preston <thomas.preston@xxxxxxxxxxxxxxx> >>> Cc: Patrick Glaser <pglaser@xxxxxxxxx> >>> Cc: Rob Duncan <rduncan@xxxxxxxxx> >>> Cc: Nate Case <ncase@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/sound/tda7802.txt | 26 +++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/tda7802.txt >>> >>> diff --git a/Documentation/devicetree/bindings/sound/tda7802.txt b/Documentation/devicetree/bindings/sound/tda7802.txt >>> new file mode 100644 >>> index 000000000000..f80aaf4f1ba0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/tda7802.txt >>> @@ -0,0 +1,26 @@ >>> +ST TDA7802 audio processor >>> + >>> +This device supports I2C only. >>> + >>> +Required properties: >>> + >>> +- compatible : "st,tda7802" >>> +- reg : the I2C address of the device >>> +- enable-supply : a regulator spec for the PLLen pin > > Shouldn't that be a pin called 'pllen-gpios'? IMHO I would not use a > regulator for that. > > Regards, > Marco > Hi Marco, We have multiple amplifiers hooked up in a chain, and all the PLLens are connected to one GPIO. So we need to use a regulator so that i2c-TDA7802:00 doesn't turn off the PLLen which i2c-TDA7802:01 still requires. This is why we use a regulator. Is there GPIO support for this? Thanks, Thomas
