On 30/07/2019 13:27, Charles Keepax wrote: > On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote: >> Signed-off-by: Thomas Preston <thomas.preston@xxxxxxxxxxxxxxx> >> Cc: Patrick Glaser <pglaser@xxxxxxxxx> >> Cc: Rob Duncan <rduncan@xxxxxxxxx> >> Cc: Nate Case <ncase@xxxxxxxxx> >> --- >> .../devicetree/bindings/sound/tda7802.txt | 26 +++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/tda7802.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/tda7802.txt b/Documentation/devicetree/bindings/sound/tda7802.txt >> new file mode 100644 >> index 000000000000..f80aaf4f1ba0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/tda7802.txt >> @@ -0,0 +1,26 @@ >> +ST TDA7802 audio processor >> + >> +This device supports I2C only. >> + >> +Required properties: >> + >> +- compatible : "st,tda7802" >> +- reg : the I2C address of the device >> +- enable-supply : a regulator spec for the PLLen pin >> + >> +Optional properties: >> + >> +- st,gain-ch13 : gain for channels 1 and 3 (range: 1-4) >> +- st,gain-ch24 : gain for channels 2 and 3 (range: 1-4) > > I wouldn't have expected the gains to be available as a device > tree setting. > Ah, I forgot to update the docs from v1. Thanks