On 19-07-19, 17:45, Niklas Cassel wrote: > Hello Viresh, > > Could you please have a look at the last two patches here: > https://git.linaro.org/people/niklas.cassel/kernel.git/log/?h=cpr-opp-hz There is no sane way of providing review comments with a link to the git tree :) I still had a look and I see that you don't search for max frequency but just any OPP that has required-opps set to the level u want. Also, can't there be multiple phandles in required-opps in your case ? > If you like my proposal then I could send out the first patch (the one to > OPP core) as a real patch (with an improved commit message), and > incorporate the second patch into my CPR patch series when I send out a V2. Send them both in your series only, otherwise the first one is useless anyway. -- viresh