On Mon, Jul 22, 2019 at 09:53:00PM +0200, Evgeny Kolesnikov wrote: > This patchset consists of the DTS, which describes the WD MyCloud EX2 Ultra device, > 'poweroff' and 'resert' drivers for power-managing MCUs connected to a board via UART > (these drivers are more versatile than qnap-poweroff and could be used as a substitude), > and DT bindings for these drivers. > > The difference between uart-poweroff and qnap-poweroff is small, but important: > uart-poweroff is able to send to an MCU a command of arbitrary length, and the command > itself is defined in a DTS file for a specific device/board, thus making this driver > applicable to wider range of devices. Hi Evgeny There is a lot of replicated code here, and in the original qnap-poweroff.c driver. Please consolidate it by extending the current driver. It should be easy to add a new compatible string, and turn power_off_cfg.cmd into an array. Andrew
