On Wed, Jul 17, 2019 at 9:36 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > On 17-07-19, 13:29, Saravana Kannan wrote: > > On Wed, Jul 17, 2019 at 12:54 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > > > > > On 02-07-19, 18:10, Saravana Kannan wrote: > > > > Interconnects often quantify their performance points in terms of > > > > bandwidth. So, add opp-peak-KBps (required) and opp-avg-KBps (optional) to > > > > allow specifying Bandwidth OPP tables in DT. > > > > > > > > opp-peak-KBps is a required property that replace opp-hz for Bandwidth OPP > > > > tables. > > > > > > > > opp-avg-KBps is an optional property that can be used in Bandwidth OPP > > > > tables. > > > > > > > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > > > --- > > > > Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++--- > > > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > > > index 76b6c79604a5..c869e87caa2a 100644 > > > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > > > @@ -83,9 +83,14 @@ properties. > > > > > > > > Required properties: > > > > - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a > > > > - required property for all device nodes but devices like power domains. The > > > > - power domain nodes must have another (implementation dependent) property which > > > > - uniquely identifies the OPP nodes. > > > > + required property for all device nodes but for devices like power domains or > > > > + bandwidth opp tables. The power domain nodes must have another (implementation > > > > + dependent) property which uniquely identifies the OPP nodes. The interconnect > > > > + opps are required to have the opp-peak-bw property. > > > > > > ?? > > > > Sorry, what's the question? Was this an accidental email? > > Too much smartness is too bad sometimes, sorry about that :) > > I placed the ?? right below "opp-peak-bw", there is no property like > that. You failed to update it :) Ah, "typo". I'll fix it. -Saravana
