Hi, Daniel > On 02/07/2019 11:03, Anson Huang wrote: > > Hi, Daniel > > > >> Hi Anson, > >> > >> why did you resend the series? > > > > Previous patch series has build warning and I did NOT notice, sorry > > for that, > > > > drivers/clocksource/timer-of.c: In function ‘timer_of_init’: > > drivers/clocksource/timer-of.c:185:30: warning: suggest parentheses > around comparison in operand of ‘&’ [-Wparentheses] > > if (to->flags & clock_flags == clock_flags) > > ^ > > > > so I resend the patch series with below, sorry for missing mention of the > changes in resent patch series. > > > > + if ((to->flags & clock_flags) == clock_flags) > > > > Sorry for mail storm... > > No problem at all, I prefer this caught and fixed early :) > > Next time just send a V5 because 'resend' means there is no change but > there was a problem with the email (could be also interpreted as a gentle > ping). OK, will keep it in mind, thanks for sharing useful experience! Thanks, Anson