On Mon, Jul 01, 2019 at 10:43:12PM +0200, Heiner Kallweit wrote: > On 01.07.2019 21:52, Matthias Kaehlcke wrote: > > The RTL8211E has extension pages, which can be accessed after > > selecting a page through a custom method. Add a function to > > modify bits in a register of an extension page and a few > > helpers for dealing with ext pages. > > > > rtl8211e_modify_ext_paged() and rtl821e_restore_page() are > > inspired by their counterparts phy_modify_paged() and > > phy_restore_page(). > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > --- > > This code might be applicable to other Realtek PHYs, but I don't > > have access to the datasheets to confirm it, so for now it's just > > for the RTL8211E. > > > This extended page mechanism exists on a number of older Realtek > PHY's. For most extended pages however Realtek releases no public > documentation. > Considering that we use these helpers in one place only, I don't > really see a need for them. I see it as self-documenting code, that may be reused, rather than inline code with comments. In any case I'm looking into another patch that would write registers on extented pages rather than doing a modify, if that materializes I think we would want the helpers.
