Hi Miquel, > > Please always Cc: Rob (robh+dt@xxxxxxxxxx) when you send bindings > related patches. Understood. thanks for your remind. > > > > > > > > > +- reg: should contain 1 entrie for the registers > > > > > > entry > > > > > > > +- reg-names: should contain "regs" > > > > > > Not sure you need that? > > > > for a base address of ctlr registers. > > Yes I know, I mean: you don't necessarily need the 'reg-names' property > as it is supposed that the only entry will be the IP registers (unless > there are more). I don't know what's Rob preference here but I would > either drop the reg-names property or enhance the name, "regs" is > terribly not descriptive. Got it, any comment is appreciated for either drop the reg-names property or enhance the name. > > > > > +- interrupts: interrupt line connected to this NAND controller > > > > +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk" > > > > +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and > > > > + "send_dly_clk" clocks > > > > > > s/entries/phandles/ ? > > > > ? > > as I know that kernel views the phandle values as device tree structure > > information instead of device tree data and thus does not store them as > > properties. > > The bindings have nothing to do with the kernel views. They might > actually be merged in a different project, out of the kernel. > if patch to phandle, should we also patch driver to of_xxx_phandle()? thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
