Re: [PATCH v5 08/10] media: dt-bindings: Document i.MX8MQ and i.MX8MM VPU bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/28/19 10:42 AM, Hans Verkuil wrote:
> Two typos for imx8mm:
> 
> On 6/12/19 11:39 AM, Philipp Zabel wrote:
>> Add devicetree binding documentation for the Hantro G1/G2 VPU on i.MX8MQ
>> and for the Hantro G1/G2/H1 VPU on i.MX8MM.
>>
>> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/media/imx8m-vpu.txt   | 56 +++++++++++++++++++
>>  1 file changed, 56 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/imx8m-vpu.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/imx8m-vpu.txt b/Documentation/devicetree/bindings/media/imx8m-vpu.txt
>> new file mode 100644
>> index 000000000000..659bd28dd002
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/imx8m-vpu.txt
>> @@ -0,0 +1,56 @@
>> +device-tree bindings for Hantro G1/G2/H1 VPU codecs implemented on i.MX8M SoCs
>> +
>> +Required properties:
>> +- compatible: value should be one of the following
>> +		"nxp,imx8mq-vpu",
>> +		"nxp,imx8mm-vpu";
>> +- regs: VPU core and control block register ranges
>> +- reg-names: should be
>> +		"g1", "g2", "ctrl" on i.MX8MQ,
>> +		"g1", "g2", "h1", "ctrl" on i.MX8MM.
>> +- interrupts: encoding and decoding interrupt specifiers
>> +- interrupt-names: should be
>> +		"g1", "g2" on i.MX8MQ,
>> +		"g1", "g2", "h1" on i.MX8MM.
>> +- clocks: phandle to VPU core clocks and bus clock
>> +- clock-names: should be
>> +		"g1", "g2", "bus" on i.MX8MQ,
>> +		"g1", "g2", "h1", "bus" on i.MX8MM.
>> +- power-domains: phandle to power domain node
>> +
>> +Examples:
>> +
>> +	vpu: vpu@38300000 {
>> +		compatible = "nxp,imx8mq-vpu";
>> +		reg = <0x38300000 0x10000>,
>> +		      <0x38310000 0x10000>,
>> +		      <0x38320000 0x10000>;
>> +		reg-names = "g1", "g2", "ctrl";
>> +		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
>> +			     <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
>> +		interrupt-names = "g1", "g2";
>> +		clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>,
>> +			 <&clk IMX8MQ_CLK_VPU_G2_ROOT>,
>> +			 <&clk IMX8MQ_CLK_VPU_DEC_ROOT>;
>> +		clock-names = "g1", "g2", "bus";
>> +		power-domains = <&pgc_vpu>;
>> +	};
>> +
>> +	vpu: vpu@38300000 {
>> +		compatible = "nxp,imx8mm-vpu";
>> +		reg = <0x38300000 0x10000>,
>> +		      <0x38310000 0x10000>,
>> +		      <0x38320000 0x10000>;
> 
> ; -> ,
> 
>> +		      <0x38330000 0x10000>;
>> +		reg-names = "g1", "g2", "h1", "ctrl";
>> +		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
>> +			     <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> 
> ; -> ,
> 
>> +			     <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
>> +		interrupt-names = "g1", "g2", "h1";
>> +		clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>,
>> +			 <&clk IMX8MQ_CLK_VPU_G2_ROOT>,
>> +			 <&clk IMX8MQ_CLK_VPU_H1_ROOT>,
>> +			 <&clk IMX8MQ_CLK_VPU_DEC_ROOT>;

More typos: IMX8MQ -> IMX8MM for the 4 lines above.

Regards,

	Hans

>> +		clock-names = "g1", "g2", "h1", "bus";
>> +		power-domains = <&pgc_vpu>;
>> +	};
>>
> 
> Regards,
> 
> 	Hans
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux