Hi, >> - clk_prepare_enable(pdata->clk); >> + ret = clk_prepare_enable(pdata->clk); >> + if (ret) >> + return ret; >> >> /* Turn on the clock and the crystal */ >> writel(RTC_CCR_EN, pdata->csr_base + RTC_CCR); >> >> - device_init_wakeup(&pdev->dev, 1); >> + ret = device_init_wakeup(&pdev->dev, 1); >> + if (ret) >> + return ret; >> > If the init fails you should unprepare (though I suspect the same issue > applies to other things in the probe function anyway). If you fix that > then feel free to add: > Okay... This is the only place missed. I don't see issue with other locations. I will post another version soon. -Loc -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
