On Fri, Apr 11, 2014 at 05:33:38PM -0600, Loc Ho wrote: > - clk_prepare_enable(pdata->clk); > + ret = clk_prepare_enable(pdata->clk); > + if (ret) > + return ret; > > /* Turn on the clock and the crystal */ > writel(RTC_CCR_EN, pdata->csr_base + RTC_CCR); > > - device_init_wakeup(&pdev->dev, 1); > + ret = device_init_wakeup(&pdev->dev, 1); > + if (ret) > + return ret; > If the init fails you should unprepare (though I suspect the same issue applies to other things in the probe function anyway). If you fix that then feel free to add: Reviewed-by: Mark Brown <broonie@xxxxxxxxxx> or anyway I guess.
Attachment:
signature.asc
Description: Digital signature
