On 11/06/2019 10:42, Jonathan Cameron wrote: >> diff --git a/include/linux/iommu.h b/include/linux/iommu.h >> index 519e40fb23ce..b91df613385f 100644 >> --- a/include/linux/iommu.h >> +++ b/include/linux/iommu.h >> @@ -536,6 +536,7 @@ struct iommu_fwspec { >> struct fwnode_handle *iommu_fwnode; >> void *iommu_priv; >> u32 flags; >> + u32 num_pasid_bits; > > This structure has kernel doc so you need to add something for this. Good catch Thanks, Jean