> >> - reg-names - register memory area names: > >> "xhci" - for HOST registers space > >> "dev" - for DEVICE registers space > >> "otg" - for OTG/DRD registers space > >> - compatible: Should contain: > >> "cdns,usb3-1.0.0" - for 0x00024502 controller version > >> "cdns,usb3-1.0.1" - for 0x00024509 controller version > >> "cdns,usb3-1.0.2" - for 0x0002450C controller version > >> "cdns,usb3-1.0.3" - for 0x0002450d controller version > > > >If the value can be read from register, why we still need different compatibles? > We don't need it. I left it only as information that cdns3 controller exist in 4 different > version. > So, you will have only one compatible at both driver and binding doc, eg "cdns, usb3"? And you may move the controller information into the driver, and have a MACRO for it? > >> Maybe I should add also something for usb2_phy in dt-binding and in driver ? > >> > > > >The PHY driver is located at: drivers/phy/cadence/phy-cadence-sierra.c. > >Will we need another one for USB2 PHY? > > As I know sierra phy is USB3.0 phy. > Also I know that we have torent phy driver for 2.0. It's ready but is has not yet in > kernel. > So I assume that I should change > phys = <&usb3_phy>; > phy-names = "cdns3,usbphy"; > > with: > phys = <&usb2_phy>, <&usb3_phy>; > phy-names = "cdns3,usbphy2", "cdns3,usbphy3"; > Yes, I think so. Peter
