> - reg-names - register memory area names: > "xhci" - for HOST registers space > "dev" - for DEVICE registers space > "otg" - for OTG/DRD registers space > - compatible: Should contain: > "cdns,usb3-1.0.0" - for 0x00024502 controller version > "cdns,usb3-1.0.1" - for 0x00024509 controller version > "cdns,usb3-1.0.2" - for 0x0002450C controller version > "cdns,usb3-1.0.3" - for 0x0002450d controller version If the value can be read from register, why we still need different compatibles? > Example: > usb@f3000000 { > compatible = "cdns,usb3-1.0.1"; > interrupts = <GIC_USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>, > <GIC_USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>, > <GIC_USB_IRQ 8 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "host", "peripheral", "otg"; > reg = <0xf3000000 0x10000>, /* memory area for HOST registers */ > <0xf3010000 0x10000>, /* memory area for DEVICE registers */ > <0xf3020000 0x10000>; /* memory area for OTG/DRD registers > */ > reg-names = "xhci", "dev", "otg"; > phys = <&usb3_phy>; > phy-names = "cdns3,usbphy"; > > > Maybe I should add also something for usb2_phy in dt-binding and in driver ? > The PHY driver is located at: drivers/phy/cadence/phy-cadence-sierra.c. Will we need another one for USB2 PHY? Peter > Thanks, > Regards, > Pawel > > >> > >> Regards, > >> Pawel > >> > >> > >>> > >>>> + > >>>> +Optional properties: > >>>> + - maximum-speed : valid arguments are "super-speed", "high-speed" and > >>>> + "full-speed"; refer to usb/generic.txt > >>>> + - dr_mode: Should be one of "host", "peripheral" or "otg". > >>>> + - phys: reference to the USB PHY > >>>> + > >>>> +Example: > >>>> + usb@f3000000 { > >>>> + compatible = "cdns,usb3-1.0.1"; > >>>> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; > >>> > >>> This example won't work as code requests for 3 separate interrupts. > >>> > >>>> + reg = <0xf3000000 0x10000 /* memory area for HOST > registers */ > >>>> + 0xf3010000 0x10000 /* memory area for DEVICE > registers */ > >>>> + 0xf3020000 0x10000>; /* memory area for > OTG/DRD registers */ > >>>> + reg-names = "xhci", "dev", "otg"; > >>>> + }; > >>>> > >>> > > > > > >-- > >cheers, > >-roger > > > >Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > >Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki