Re: [PATCH v2 1/2] dt-bindings: Add docs for EL15203000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oleh

On 6/7/19 4:17 PM, Oleh Kravchenko wrote:
Dan,

On 08.06.19 00:04, Dan Murphy wrote:
Oleh
But this is not really max_brightness now this is a feature and now
does not make sense in this context
You may need to use something different for this property or expose
a file in the driver.


Protocol for this board define 0x32 as brightness level.
This behaviur needed to keep backward compatibity.


Backwards compatibility to what?
With old/new boards.

This does not make sense.

How would a device tree entry or a file that controls the blinking have to deal with the hardware?

If it allows feature setting then you should create a bool in the device tree.

el15203000-blink;

If the board supports the feature you set this and create a file to dis/enable the feature.

If the board does not support it then no file is created.

max_brightness for this device appears to be 1.

Dan


This is a new driver there should be no DT that has this compatible or
definition.

I will let Rob ack or nack this node.

Dan





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux