Re: [PATCH v2 1/2] dt-bindings: Add docs for EL15203000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oleh

On 6/7/19 3:53 PM, Oleh Kravchenko wrote:

07.06.19 23:14, Dan Murphy пише:
Oleh

On 6/7/19 1:40 PM, Oleh Kravchenko wrote:
+LED sub-node properties:
+- label :
+    see Documentation/devicetree/bindings/leds/common.txt
Add this

Optional LED sub-node properties:

And remove (optional) from the below.

Done

+- linux,default-trigger : (optional)
+    see Documentation/devicetree/bindings/leds/common.txt
+- max-brightness : (optional)
+    Specify here 2 if LED has special effect. Effects by LED type:
s/Specify here 2/Specify 2

Done

But this is not really max_brightness now this is a feature and now does not make sense in this context

You may need to use something different for this property or expose a file in the driver.


Protocol for this board define 0x32 as brightness level.
This behaviur needed to keep backward compatibity.


Backwards compatibility to what?

This is a new driver there should be no DT that has this compatible or definition.

I will let Rob ack or nack this node.

Dan




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux