Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring:
> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
> > Hi Rob,
> >
> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
> >> > From: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> >> >
> >> > When using interrupt-maps, the size of a map entry is #address-cells +
> >>
> >> Plus what? You mean ", and "?
> >>
> > Urgh, I obviously messed this up while editing the commit message in the
> > last minute. It should have been something along the lines of:
> >
> > When using interrupt-maps, the size of a map entry is #address-cells +
> > #interrupt-cells. address-cells should be 0 as this offset is not used
> > in the GIC.
> >
> > As #address-cells = <0> is the same as not specifying the
> > property, simply remove it.
> >
> > Can you edit this while applying, or should I send a new patch?
> 
> I'll fix it up and apply.
> 
Thanks.

> >
> >> > address-cells should be 0 as this is not used.
> >> >
> >> > As #address-cells = <0> is the same as not specifying the
> >> > property, simply remove it.
> >> >
> >> > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> >> > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> >>
> >> Did this get applied? I can't seem to find patch 2.
> >>
> > As Shawn pointed out patch 2 got applied through the imx tree as it
> > fixes a real bug there.
> 
> It was highlighted that other instances beyond iMX were wrong. Please
> fix those as well.

Oh, I wasn't aware of that. Will send patches.

Regards,
Lucas

-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux