Hi, On Tue, Jun 04, 2019 at 03:45:17PM +0100, Mark Brown wrote: > On Tue, Jun 04, 2019 at 10:54:49AM +0200, Maxime Ripard wrote: > > The current computation for the SR (sample resolution) and the WSS (word > > slot size) register parameters is based on a switch returning the matching > > parameters for a given params width. > > This doesn't build for me with current code: > > CC sound/soc/sunxi/sun4i-i2s.o > sound/soc/sunxi/sun4i-i2s.c:169:28: warning: ‘struct sun4i_i2s’ declared inside parameter list will not be visible outside of this definition or declaration > s8 (*get_sr)(const struct sun4i_i2s *, int); > ^~~~~~~~~ > sound/soc/sunxi/sun4i-i2s.c:170:29: warning: ‘struct sun4i_i2s’ declared inside parameter list will not be visible outside of this definition or declaration > s8 (*get_wss)(const struct sun4i_i2s *, int); > ^~~~~~~~~ > > and lots of similar stuff. Sigh, so much for sending a patch part of a branch... Sorry for wasting your time on this, I've sent a v2 with this fixed. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
