On Thu, Apr 10, 2014 at 12:47:57PM -0600, Loc Ho wrote:
> + if (device_may_wakeup(&pdev->dev)) {
> + if (!enable_irq_wake(irq))
> + pdata->irq_wake = 1;
> + } else {
> + pdata->irq_enabled = xgene_rtc_alarm_irq_enabled(dev);
> + xgene_rtc_alarm_irq_enable(dev, 0);
> + clk_disable(pdata->clk);
> + }
> + clk_unprepare(pdata->clk);
This will unconditionally unprepare the clock even if it wasn't disabled
which looks like a bug - I would have expected the disable to be a
clk_disable_unprepare() instead? Similarly for the resume path.
Otherwise this looks good to me.
Attachment:
signature.asc
Description: Digital signature
