Re: [PATCH 05/13] extcon: extcon-class: improve extcon client API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Thu, Apr 10, 2014 at 03:16:43PM +0200, Robert Baldyga wrote:
> +struct extcon_cable *extcon_get_cable_by_name(struct device *dev,
> +						 const char *name)
> +{
> +	return of_extcon_get_cable_by_name(dev->of_node, name);
> +}
> +EXPORT_SYMBOL_GPL(extcon_get_cable_by_name);

[...]

> @@ -96,17 +95,13 @@ static int omap_otg_probe(struct platform_device *pdev)
>  {
>  	const struct omap_usb_config *config = pdev->dev.platform_data;
                                                         ^^^^^^^^^^^^^

[...]

> -	ret = extcon_register_interest(&otg_dev->id_dev, config->extcon,
> -				       "USB-HOST", &otg_dev->id_nb);
> +	cable_id = extcon_get_cable_by_name(&pdev->dev, "USB-HOST");

NACK. OMAP1 is not using DT, so this driver would stop working
with this series.

A.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux